The important physical interpretation that you need to keep in mind is that the charges are opposite, so the $1/r$ pieces of their potentials cancel out. We'll see this happen explicitly in the math in the correct derivation.
But it also explains why your logic isn't quite enough to understand what's going on: You really do need those two opposite charges to cancel out the $1/r$ pieces. So you shouldn't start from just $V = kQ/r$ and then find the approximation for $r$ by plugging in the correct answer that you don't yet understand. That's not a helpful way of going about it. Instead, you should do the full derivation yourself.
First of all, I hope you can see from the geometry that
\begin{equation}
r \approx b + \frac{LM}{2} \approx c - \frac{LM}{2}.
\end{equation}
The reason is that as you take $P$ very far away, those lines $c$, $b$, and $r$ all become basically parallel, and they squeeze down onto each other. So $c$, $b$, and $r$ just represent different points along (roughly) the same line.
Now, accepting the equation above, you can immediately see that $LM \approx c-b$. You can also see that
\begin{align}
r^2
&\approx \left(b + \frac{LM}{2}\right)\left(c -\frac{LM}{2} \right) \\
&\approx bc + (c-b)\frac{LM}{2} - \frac{LM^2}{4} \\
&\approx bc + LM\frac{LM}{2} - \frac{LM^2}{4} \\
&\approx bc + \frac{LM^2}{4}
\end{align}
But when $r \gg a$ (and because $a \geq LM$), we know that $LM^2/4$ must have a small effect on the result, so we can just ignore it: $r^2 \approx bc$. That explains the two approximations shown in your figure. But I argue that's not enough to actually understand the total potential.
So onto the real derivation. You'll agree that (without any approximation) the full expression for the potential is
\begin{align}
V
&=
\frac{kQ} {b} - \frac{kQ} {c}.
\end{align}
Note that crucial minus sign! Next, we can start inserting our approximations:
\begin{align}
V
&\approx
\frac{kQ} {r-LM/2} - \frac{kQ} {r+LM/2} \\
&\approx
\frac{kQ} {r-\frac{a\cos\theta}{2}} - \frac{kQ} {r+\frac{a\cos\theta}{2}} \\
&\approx
\frac{kQ} {r} \frac{1}{1-\frac{a\cos\theta}{2r}} - \frac{kQ} {r}
\frac{1}{1+\frac{a\cos\theta}{2r}}
\end{align}
In that last line, I haven't done anything fancy; I've simply pulled out the denominator. But now, that lets us use the approximation $\frac{1}{1 \pm x} \approx 1 \mp x$ for small $x$. In this case $x$ is $a\cos\theta / 2r$, and since $r \gg a$ this is small, so we can use that approximation:
\begin{align}
V
&\approx
\frac{kQ} {r} \left(1+\frac{a\cos\theta}{2r}\right) - \frac{kQ} {r} \left(1-\frac{a \cos\theta}{2r}\right) \\
&\approx
\frac{kQ} {r} \frac{a\cos\theta}{r} \\
&\approx
\frac{kQa\cos\theta} {r^2}.
\end{align}