[Note that Jen in their answer corrects quite a few of the premises of my question; read it. I let the question otherwise stand as-is.]
Falsifying business records in New York is only a felony if it was done in order to hide a felony. That's the legal basis of Trump's recent conviction in a state court in New York.
Now conceivably, if he is re-elected, Trump is able to pardon himself; but the Presidential power to pardon only concerns federal crimes; this is what makes the Georgia and New York cases so toxic for him. Even another term as President would not shield him from state prosecution.
The New York case is rather unusual though in that he violated state law and was tried in state court, but the state law recurs to the condition that a felony was concealed by it; in this case, it is the federal crime of a conspiracy "to undermine the integrity of a presidential election." This is an interesting construct since he has not been convicted of that federal crime; the state jury simply found it sufficiently convincing that he committed it. We know that a pardon can be given proactively, before somebody is tried or convicted. Conceivably, Trump could pardon himself for the conspiracy.
Arguably, accepting a pardon is actually an acknowledgement that one committed a crime, which is then pardoned. An accepted pardon would only reaffirm the opinion of the jury that Trump committed that crime!
Would a pardon for the federal crime which made falsifying the business records a felony in New York also void the reason for the falsifying being a felony?